Repository navigation
Fix sandboxed datetime decoding with replay compatibility - #2094
Open
VegetarianOrc wants to merge 4 commits into
Open
VegetarianOrc wants to merge 4 commits into
VegetarianOrc wants to merge 4 commits into
Conversation
VegetarianOrc
force-pushed
the
amazzeo/fix-sandboxed-datetime-decoding
branch
from
November 5, 2026 23:11
6f19941 to
9ee09ba
Compare
VegetarianOrc
marked this pull request as ready for review
November 6, 2026 00:08
|
|
||
| RAISE_ON_CANCELLING_COMPLETED_ACTIVITY = 1 | ||
| PROCESS_WORKFLOW_ACTIVATION_JOBS_AS_SINGLE_BATCH = 2 | ||
| DECODE_DATETIME_PROXIES = 3 |
Contributor
There was a problem hiding this comment.
In other SDKs we also recorded, as comments, what each flag did, when it was added, enabled and the status
Contributor
Author
There was a problem hiding this comment.
Added comments with some explanation!
| _DEFAULT_ENABLED_WORKFLOW_LOGIC_FLAGS: frozenset[_WorkflowLogicFlag] = frozenset( | ||
| { | ||
| _WorkflowLogicFlag.PROCESS_WORKFLOW_ACTIVATION_JOBS_AS_SINGLE_BATCH, | ||
| _WorkflowLogicFlag.DECODE_DATETIME_PROXIES, |
Contributor
There was a problem hiding this comment.
Did we just add DECODE_DATETIME_PROXIES flag? We should wait one minor release before enabling any flag.
Contributor
Author
There was a problem hiding this comment.
I've removed these from the default flags and adjusted the tests as appropriate. Added a todo in the comments to track enablement. I'll create an issue for enablement once merged.
VegetarianOrc
force-pushed
the
amazzeo/fix-sandboxed-datetime-decoding
branch
from
November 6, 2026 19:33
44fe1af to
229921d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the current workflow's runtime flags as a context variable. That is then used in the default payload converter to detect if it should unwrap a sandboxed
datetimetype hint to be backward compatible with existing histories.New activations set a new datetime conversion flag on start to ensure that the first WFT processed enables the flag by default and queries that arrive before the flag would be lazily set by inspection can still succeed. Setting the flag is ignored during replay as normal.
New tests have been added to replay history without the flag set and confirm that signals are dropped as before.
Summary
Fixes #2072.
datetimetype hints in the default JSON converter, preserving custom-converter precedence and existing sandbox restrictions.Validation
poe test -s --maxfail=1: 1,783 passed, 10 skipped.poe lint: passed, including pyright, mypy, basedpyright, formatting, import checks, and docstyle.git diff --check: passed.