Repository navigation
Conversation
Prevent modules without source or sink buffers from being reported as ready to process. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
November 12, 2026 09:56
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change that prevents fully disconnected modules from being considered ready to process.
No open issues 🎉
What changed in this PR
Updates the module adapter’s generic readiness check so fully disconnected modules are not reported as ready to process.
Changes:
- Returns
falsewhen both source and sink counts are zero. - Preserves existing buffer-availability checks for connected modules.
| File | Description |
|---|---|
src/include/sof/audio/module_adapter/module/generic.h |
Adds an early readiness rejection for modules with no sources or sinks. |
Review effort: Balanced
lgirdwood
approved these changes
Nov 12, 2026
PR 11447: test resultsRun date: 2026-11-12 19:36 UTC Tested commit: af333a0596d005c8b3c6977a98c3ef86d0bc2095
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent modules without source or sink buffers
from being reported as ready to process.