Skip to content

audio: dax: fixes regarding the results of coverity check #11454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
checkupup wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audio: dax: fixes regarding the results of coverity check #11454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/audio/module_adapter/module/dolby/dax.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,19 @@ static int32_t flag_process(struct dax_adapter_data *adapter_data,
enum dax_flag_opt_mode opt_mode)
{
#ifdef __ZEPHYR__
int32_t bit = ffs(flag) - 1;
atomic_val_t mask = (atomic_val_t)flag;

@lgirdwood lgirdwood Nov 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@checkupup sorry not following the commit message here, not following what is being treated as an array by the compiler ?


switch (opt_mode) {
case DAX_FLAG_READ:
return atomic_test_bit(&adapter_data->proc_flags, bit);
return (atomic_get(&adapter_data->proc_flags) & mask) != 0;
case DAX_FLAG_SET:
atomic_set_bit(&adapter_data->proc_flags, bit);
atomic_or(&adapter_data->proc_flags, mask);
break;
case DAX_FLAG_CLEAR:
atomic_clear_bit(&adapter_data->proc_flags, bit);
atomic_and(&adapter_data->proc_flags, ~mask);
break;
case DAX_FLAG_READ_AND_CLEAR:
return atomic_test_and_clear_bit(&adapter_data->proc_flags, bit);
return (atomic_and(&adapter_data->proc_flags, ~mask) & mask) != 0;
default:
break;
}
Expand Down
Loading