Skip to content

audio: eq_iir: fix silent output in pass-through mode (and other fixes) #11458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kv2019i wants to merge 2 commits into
base: main
Choose a base branch
from
Open

audio: eq_iir: fix silent output in pass-through mode (and other fixes) #11458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f95b3d
audio: eq_iir: fix silent output in pass-through mode
kv2019i Nov 13, 2026
c47216d
audio: eq_iir: ipc3: fix pointer double advance in s32 pass functions
kv2019i Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/audio/eq_iir/eq_iir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ void eq_iir_pass(struct processing_module *mod, const struct cir_buf_source *sou
const uint8_t *src = source->ptr;
uint8_t *dst = sink->ptr;
size_t bytes = frames * cd->frame_bytes;
int ret;

while (bytes) {
size_t src_contiguous = (const uint8_t *)source->buf_end - src;
Expand All @@ -337,7 +338,8 @@ void eq_iir_pass(struct processing_module *mod, const struct cir_buf_source *sou
continue;
}

assert(!memcpy_s(dst, dst_contiguous, src, copy));
ret = memcpy_s(dst, dst_contiguous, src, copy);
assert(!ret);
bytes -= copy;
src = source_cir_buf_wrap(src + copy, source->buf_start, source->buf_end);
dst = cir_buf_wrap(dst + copy, sink->buf_start, sink->buf_end);
Expand Down
8 changes: 4 additions & 4 deletions src/audio/eq_iir/eq_iir_ipc3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ static void eq_iir_s32_s16_pass(struct processing_module *mod,
y++;
}
remaining_samples -= n;
x = source_cir_buf_wrap(x + n, source->buf_start, source->buf_end);
y = cir_buf_wrap(y + n, sink->buf_start, sink->buf_end);
x = source_cir_buf_wrap(x, source->buf_start, source->buf_end);
y = cir_buf_wrap(y, sink->buf_start, sink->buf_end);
}
}
#endif /* CONFIG_FORMAT_S16LE && CONFIG_FORMAT_S32LE */
Expand Down Expand Up @@ -181,8 +181,8 @@ static void eq_iir_s32_s24_pass(struct processing_module *mod,
y++;
}
remaining_samples -= n;
x = source_cir_buf_wrap(x + n, source->buf_start, source->buf_end);
y = cir_buf_wrap(y + n, sink->buf_start, sink->buf_end);
x = source_cir_buf_wrap(x, source->buf_start, source->buf_end);
y = cir_buf_wrap(y, sink->buf_start, sink->buf_end);
}
}
#endif /* CONFIG_FORMAT_S24LE && CONFIG_FORMAT_S32LE */
Expand Down
Loading