Repository navigation
Read the overlay owner flag as isOwnedByOU and accept the text of a select option - #174
Merged
brionmario merged 1 commit intoNov 16, 2026
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
🔀 Cross-SDK feature parity, ports raisedThis pull request is labelled Ports (DO NOT EDIT)
3 of 3 sibling SDKs accounted for. Every sibling SDK is accounted for. The contract is in the SDK development specification. |
AmshikaH
marked this pull request as draft
November 12, 2026 05:31
…elect option Signed-off-by: AmshikaH <amshikahameed@gmail.com>
AmshikaH
force-pushed
the
flow-variable-owner-flag-and-select
branch
from
November 16, 2026 03:39
8a97655 to
5c946cc
Compare
AmshikaH
marked this pull request as ready for review
November 16, 2026 03:46
brionmario
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Two small corrections to the flow variable helpers added in #162, so they match what the server does:
isOwnedByOUonly.resolveFlowVariableRulereadoverlay.owned ?? overlay.isOwned, andResolvedOverlaydeclaredisOwned,isOwnedByOUandowned. The server returnsisOwnedByOUfor every resource, flows included (ResolvedOverlayResponsein the ThunderID backend), soisOwnedandownedwere never sent for a flow.validateFlowVariableValueaccepts the text of aSELECToption.getFlowVariableOptionsreturns every option'svalueas a string, sooptions: [true, false]gives"true"and"false", and the validator then rejected them withnot_option. The server compares a select value by its text (rawFromScalar), so"true"is valid for an optiontrue.Approach
resolveFlowVariableRulereadsoverlay.isOwnedByOU. The React and VueBaseSharingPoliciesand the four playgrounds read the same field.SELECTcase ofvalidateFlowVariableValuecomparesString(option) === String(value). It only accepts more values than before, so nothing that was valid becomes invalid.BOOLEAN_INPUTstill needs a real boolean, as on the server.FlowVariablesFormis unaffected by the select change: it already maps the chosen string back to the declared option before saving.Related Issues
Related PRs
Checklist
breaking changelabel added.parity/prs-raisedorparity/prs-not-neededadded.parity/prs-raised, the port links are posted as a reply on the parity check's comment.Security checks
SDK parity