Skip to content

Read the overlay owner flag as isOwnedByOU and accept the text of a select option - #174

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
AmshikaH:flow-variable-owner-flag-and-select
Nov 16, 2026
Merged

brionmario merged 1 commit into
thunder-id:mainfrom
AmshikaH:flow-variable-owner-flag-and-select

Conversation

@AmshikaH

@AmshikaH AmshikaH commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Purpose

Two small corrections to the flow variable helpers added in #162, so they match what the server does:

  • The resolved overlay owner flag is isOwnedByOU only. resolveFlowVariableRule read overlay.owned ?? overlay.isOwned, and ResolvedOverlay declared isOwned, isOwnedByOU and owned. The server returns isOwnedByOU for every resource, flows included (ResolvedOverlayResponse in the ThunderID backend), so isOwned and owned were never sent for a flow.
  • validateFlowVariableValue accepts the text of a SELECT option. getFlowVariableOptions returns every option's value as a string, so options: [true, false] gives "true" and "false", and the validator then rejected them with not_option. The server compares a select value by its text (rawFromScalar), so "true" is valid for an option true.

Approach

  • resolveFlowVariableRule reads overlay.isOwnedByOU. The React and Vue BaseSharingPolicies and the four playgrounds read the same field.
  • The SELECT case of validateFlowVariableValue compares String(option) === String(value). It only accepts more values than before, so nothing that was valid becomes invalid. BOOLEAN_INPUT still needs a real boolean, as on the server.
  • FlowVariablesForm is unaffected by the select change: it already maps the chosen string back to the declared option before saving.

Related Issues

  • N/A

Related PRs

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.
  • Cross-SDK parity. Exactly one of parity/prs-raised or parity/prs-not-needed added.
    • If parity/prs-raised, the port links are posted as a reply on the parity check's comment.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

SDK parity

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Pre-merge checks: Inconclusive 2

Failed Failed checks: 2 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Description check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🔀 Cross-SDK feature parity, ports raised

This pull request is labelled parity/prs-raised, so the capability it introduces is expected in the other ThunderID SDKs as well.

Ports (DO NOT EDIT)

  • thunder-id/ios-sdks, iOS => #49
  • thunder-id/android-sdks, Android => #59
  • thunder-id/flutter-sdks, Flutter => #69

3 of 3 sibling SDKs accounted for.

Every sibling SDK is accounted for.

The contract is in the SDK development specification.

…elect option

Signed-off-by: AmshikaH <amshikahameed@gmail.com>
@AmshikaH
AmshikaH force-pushed the flow-variable-owner-flag-and-select branch from 8a97655 to 5c946cc Compare November 16, 2026 03:39
@AmshikaH
AmshikaH marked this pull request as ready for review November 16, 2026 03:46
@brionmario brionmario added the parity/prs-raised Ports exist in the other SDKs, or are recorded as not applying there label Nov 16, 2026
@brionmario
brionmario merged commit 6d3a776 into thunder-id:main Nov 16, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parity/prs-raised Ports exist in the other SDKs, or are recorded as not applying there

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants