Skip to content

Prepare the 0.0.1a1 pre-release for PyPI - #2

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
sahandilshan:release-prep
Nov 13, 2026
Merged

brionmario merged 1 commit into
thunder-id:mainfrom
sahandilshan:release-prep

Conversation

@sahandilshan

Copy link
Copy Markdown
Contributor

Purpose

Prepare the first PyPI release of the Python SDK as the pre-release thunderid==0.0.1a1. PyPI has no draft releases, so a pre-release is the closest equivalent: pip and uv install it only when asked for explicitly.

Design: thunder-id/thunderid discussion 5877.

Approach

  • release.yml: split into build, publish and github-release jobs. publish runs in the protected pypi environment and uploads with PyPI Trusted Publishing (id-token: write on that job only), so no PYPI_TOKEN secret is stored. --check-url lets a re-run skip files that are already on PyPI.
  • The GitHub release is titled ThunderID Python SDK <tag>, like the other SDKs (for example ThunderID Android SDK v1.10.0). It is marked as a pre-release unless the version is a final release.
  • pyproject.toml and uv.lock: version 0.0.1a1. The workflow checks that the tag matches it.
  • README.md becomes the PyPI project page. The install line is now pip install "thunderid>=0.0.1a1", which allows the pre-release without pulling pre-releases of dependencies, and relative links are now absolute GitHub links.
  • tests/e2e/README.md: replace the old token-based release note with the Trusted Publishing setup.

Before tagging v0.0.1a1, a repository admin needs to create the pypi environment with required reviewers and deployments limited to v* tags, and the PyPI pending publisher must be registered (project thunderid, owner thunder-id, repository python-sdks, workflow release.yml, environment pypi).

Related Issues

Related PRs

Validation

  • uv sync --locked, uv lock --check: pass
  • uv run ruff check ., uv run ruff format --check .: pass
  • uv run mypy src examples: pass
  • uv run pytest: 128 passed, 4 skipped (real-server tests, THUNDERID_E2E_SETTINGS not set)
  • uv build and twine check --strict dist/*: pass
  • Ran the workflow's tag check (v0.0.1a1) and pre-release detection (prerelease=true) locally.
  • Skipped: actionlint (not installed locally) and the release workflow itself, which only runs on a tag.

SDK parity

  • JavaScript SDKs: not applicable, Python packaging and release only.
  • iOS SDKs: not applicable, Python packaging and release only.
  • Android SDKs: not applicable, Python packaging and release only.
  • Flutter SDKs: not applicable, Python packaging and release only.

Checklist

  • Followed the contribution guidelines.
  • Added or updated relevant documentation and tests.
  • Recorded validation results and any skipped checks.
  • Described any breaking changes and migration steps. (None.)

Security checks

  • Followed secure coding standards.
  • Confirmed no keys, passwords, tokens, personal data, or other secrets are committed.

🤖 Generated with Claude Code

Publish through PyPI Trusted Publishing from the protected pypi
environment instead of a stored token, mark pre-release versions as
GitHub pre-releases, and title releases like the other ThunderID SDKs.
Point the README install line and links at PyPI and GitHub, since the
README becomes the PyPI project page.

Refs thunder-id/thunderid#2530

Signed-off-by: Sahan Dilshan <sahandilshan222@gmail.com>
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🔀 Cross-SDK feature parity, no ports needed

This pull request is labelled parity/prs-not-needed: nothing here has to ship in the other ThunderID SDKs. If that changes, swap the label for parity/prs-raised.

@brionmario brionmario added parity/prs-raised Ports exist in the other SDKs, or are recorded as not applying there parity/prs-not-needed Nothing here reaches another SDK and removed parity/prs-raised Ports exist in the other SDKs, or are recorded as not applying there labels Nov 13, 2026
@brionmario
brionmario merged commit 323acee into thunder-id:main Nov 13, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parity/prs-not-needed Nothing here reaches another SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants