Repository navigation
Prepare the 0.0.1a1 pre-release for PyPI - #2
Merged
Merged
Conversation
Publish through PyPI Trusted Publishing from the protected pypi environment instead of a stored token, mark pre-release versions as GitHub pre-releases, and title releases like the other ThunderID SDKs. Point the README install line and links at PyPI and GitHub, since the README becomes the PyPI project page. Refs thunder-id/thunderid#2530 Signed-off-by: Sahan Dilshan <sahandilshan222@gmail.com>
🔀 Cross-SDK feature parity, no ports neededThis pull request is labelled |
brionmario
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Prepare the first PyPI release of the Python SDK as the pre-release
thunderid==0.0.1a1. PyPI has no draft releases, so a pre-release is the closest equivalent: pip and uv install it only when asked for explicitly.Design: thunder-id/thunderid discussion 5877.
Approach
release.yml: split intobuild,publishandgithub-releasejobs.publishruns in the protectedpypienvironment and uploads with PyPI Trusted Publishing (id-token: writeon that job only), so noPYPI_TOKENsecret is stored.--check-urllets a re-run skip files that are already on PyPI.ThunderID Python SDK <tag>, like the other SDKs (for exampleThunderID Android SDK v1.10.0). It is marked as a pre-release unless the version is a final release.pyproject.tomlanduv.lock: version0.0.1a1. The workflow checks that the tag matches it.README.mdbecomes the PyPI project page. The install line is nowpip install "thunderid>=0.0.1a1", which allows the pre-release without pulling pre-releases of dependencies, and relative links are now absolute GitHub links.tests/e2e/README.md: replace the old token-based release note with the Trusted Publishing setup.Before tagging
v0.0.1a1, a repository admin needs to create thepypienvironment with required reviewers and deployments limited tov*tags, and the PyPI pending publisher must be registered (projectthunderid, ownerthunder-id, repositorypython-sdks, workflowrelease.yml, environmentpypi).Related Issues
Related PRs
Validation
uv sync --locked,uv lock --check: passuv run ruff check .,uv run ruff format --check .: passuv run mypy src examples: passuv run pytest: 128 passed, 4 skipped (real-server tests,THUNDERID_E2E_SETTINGSnot set)uv buildandtwine check --strict dist/*: passv0.0.1a1) and pre-release detection (prerelease=true) locally.actionlint(not installed locally) and the release workflow itself, which only runs on a tag.SDK parity
Checklist
Security checks
🤖 Generated with Claude Code