Repository navigation
Conversation
A group named `Group */ Name` was written as `/* Group */ Name */`, which ends the comment early: neither XcodeProj, plutil nor Xcode could open the project afterwards.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description 📝
A group or target whose name contains
*/is written as/* Group */ Name */: the comment ends early, and neither XcodeProj,plutilnor Xcode can open the project afterwards (Expected terminating ')' for array).Solution 📦
PBXProjEncoder.write(comment:)writes*/as(*)/, as Xcode 26.3 does (/* Group (*)/ Name */). Values are not changed, so the name still reads back asGroup */ Name. Comments without*/skip the replace. The same fix is proposed for CocoaPods in CocoaPods/Nanaimo#75 and CocoaPods/Xcodeproj#1064.Implementation 👩💻👨💻
*/inwrite(comment:)Group */ Nameis written with(*)/and decodes back; it fails without the fixmise run testandmise run lintpass; a project written with the fix passesplutil -lintandxcodebuild -list