Skip to content

refactor(baserevision): Add a base revision extension - #1002

Open
manjari25 wants to merge 1 commit into
mainfrom
manjari/tango-base-revision-extension
Open

manjari25 wants to merge 1 commit into
mainfrom
manjari/tango-base-revision-extension

Conversation

@manjari25

@manjari25 manjari25 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Why?

Turns the base revision into an extension. The contract is baserevision.Resolver in submitqueue/extension/baserevision, with a mock. The git implementation moves from conflict/tango/baserevision to baserevision/git. The Tango analyzer takes a Resolver instead of a function, and the orchestrator wiring builds it. No behavior change: this is mostly a move. The README follows in the next PR.

What?

The base revision is a pluggable source, and a GitHub-backed one is next. It needs a contract and a place for its implementations that isn't under conflict/tango.

Test Plan

  • ./tool/bazel test //submitqueue/extension/baserevision/... //submitqueue/extension/conflict/tango/...
  • The existing git tests moved with the code and pass unchanged apart from the new call shape.
  • CI

Issue

@manjari25
manjari25 requested review from a team, behinddwalls and sbalabanov as code owners November 2, 2026 20:31
@manjari25
manjari25 added this pull request to stack #1004 November 2, 2026 20:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant