Repository navigation
Conversation
The Args interface, the ArgumentBase type, all 31 ArgumentBase/ArgumentsBase type aliases (StringArg, IntArg, FloatArgs, ...), and all 30 Command positional-argument accessor methods (StringArg, IntArgs, ...) had no godoc comment, so go doc/pkg.go.dev showed nothing useful for most of the positional-argument API. No behavior change, comments only. godoc-current.txt and testdata/godoc-v3.x.txt are regenerated per CONTRIBUTING.md.
coilysiren
approved these changes
Nov 7, 2026
HasName, Usage, Parse, and Get on both ArgumentBase and ArgumentsBase implement the Argument interface but had no godoc comments of their own, so they showed up undocumented in go doc/pkg.go.dev. No behavior change, comments only. godoc-current.txt and testdata/godoc-v3.x.txt are regenerated per CONTRIBUTING.md.
Author
|
While comparing this PR with #2532 (which targets the same issue, #2528), I noticed that
Happy to adjust wording or scope based on reviewer feedback. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Argsinterface, theArgumentBasetype, all 31 ArgumentBase/ArgumentsBasetype aliases (StringArg, IntArg, FloatArgs, ...), and all 30 Command
positional-argument accessor methods (StringArg, IntArgs, ...) had no godoc
comment, so
go doc/pkg.go.dev showed nothing useful for most of thepositional-argument API.
No behavior change, comments only.
godoc-current.txtandtestdata/godoc-v3.x.txtwere regenerated per CONTRIBUTING.md.Closes #2528
Note: I noticed another PR (#2532) may already address this issue —
I had started this before seeing it, so leaving it open in case it's useful
for comparison or if maintainers prefer this version.