Skip to content

fix: the fetch patch's credential fill - #180

Merged
viztor merged 267 commits into
mainfrom
claude/vigilant-mendel-bctz9n-p6
Nov 16, 2026
Merged

viztor merged 267 commits into
mainfrom
claude/vigilant-mendel-bctz9n-p6

Conversation

@viztor

@viztor viztor commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Phase P6 of docs/improvement-plan.md, on main (P5, #176, is merged).

What changed

Item Change
src/utils/credential-policy.ts (new) The pure credential rules every decider shares: the placeholder filter (usableKey, applied once at each decider's exit), the fill order and meter order per keySource, the lazy step walk, the capture gate (mayCapture) and L8's strike count. Coverage: 100%.
src/credentials.ts (new) The effect half. captureStoreFor(ctx) keeps one CaptureStore per root. createCredentials is the fetch patch's single resolver: it observes, fills, settles L8 and pins the session. The installation-store read lives here too. It is the only place the fill reads the process environment. Coverage: 100%.
src/fetch-patch.ts, src/key-capture.ts, src/go-discovery.ts These now go through the resolver and the per-root store. The module-level maps and clearCapturedApiKeys are gone, and fetch-patch.ts no longer reads process.env.
OC3 A key is recorded only from a decorated turn's request that carries no marker. A relay route's key never fills a plane request or the meter.
L8 A captured key is dropped after a second well-formed 401 in a row, counted only on decorated turns. A 2xx clears the count. No verification request is sent, and the meter's own /usage 401 never counts.
src/host/global-fetch.ts (new), src/lifecycle.ts Any disposal order now ends at the fetch that was there before, and a third party's function on top is never replaced. Both KNOWN_DEFECT P6 assertions flip. Coverage: 100%.
src/host/plane-provider.ts, src/host/route-claim.ts, src/turn-store.ts (OC4, OC5) PlaneAdapter is built with pi-ai's prepareHeaders. Each call writes the plane headers from the table the fetch patch also writes from, then runs the host's llm-pi-ai/request-headers waterfall. The seam is detected by behaviour.
src/utils/request-shape.ts pluginMarkerOn(headers) and the shared plane-header table.
OC11 The README pair states the seam's floor (0.2.2-alpha.3, 0.2.2-rc.1) and what an older host does. The typert peer is unchanged.
Tests Added: test/credential-parity.test.ts, run green on the base before any src/ edit, and new credential-policy, credentials, global-fetch and host-planes-headers files. Extended: fetch-patch, go-discovery, usage-service, lifecycle, host-planes, route-claim, plane-provider, reload, architecture and mock. The architecture tripwire pins that process.env is not read in the fetch patch, lifecycle.ts or the plane provider. A fetch-patch case runs the fallback for a host without the seam.
Docs Updated: the README pair, docs/credentials.md, docs/deep-dive.md, docs/redirect-planes.md, docs/testing.md, AGENTS.md, CONTRIBUTING.md and the plan's P6 rows.

Behaviour changes

  • Captured keys (OC3). A key is kept only from the plugin's own decorated turns. It is no longer replayed onto any request a configured provider claims. A relay route's key never fills a gateway request or the meter.
  • Dropped keys (L8). A captured key is dropped after the gateway refuses it twice in a row on its plane, on the plugin's own turns. A request outside those turns never counts against a key, and that includes the meter's poll.
  • Placeholders. A blank exported key, or a placeholder in the installation's store, is no longer sent as a credential. A blank or placeholder OPENCODE_API_KEY no longer counts as Zen credit.
  • Disposal order. Disabling two overlapping activations, in either order, leaves the fetch that was there before them.
  • Per-call headers (OC4, OC5). On a host with the seam (0.2.2-alpha.3, 0.2.2-rc.1 and later), the planes' session, origin and project headers are written per call, and other plugins' llm-pi-ai/request-headers contributors run on the planes. A contributor that throws fails the turn with REQUEST_HEADERS. On an older host, the fetch patch writes the plugin's headers as before.
  • Unchanged. L4 is undecided, so x-opencode-request is still sent. The supported harness range is unchanged.

Peer range (OC11). This was decided at landing, for the owner: the typert peer keeps >=0.2.1-alpha.1 <0.3.0 || >=0.2.2-0 <0.3.0. A narrowing to >=0.2.2-alpha.3 landed as its own commit and was reverted, for three reasons:

  1. fix(deps): declare support for the Cordis 4.1 line and the rc channel #163 kept the optional cordis peer's clauses for the 0.2.1 hosts' core.
  2. D26 says host gaps are feature-detected, never compared by version.
  3. On a host without the seam, the fetch patch still writes the plugin's headers, so refusing those hosts at install buys nothing.

Reverting 524e95a alone restores the narrowing.

Review

The chain ran three rounds:

Round Found Upheld Fixed
1 24 24 (3 high, 4 medium, 17 low) 24
2 6 6 6
3 3 3 3

The peer revert then had its own review: round 1 upheld 2 of 5 findings and round 2 upheld 1 of 3, all fixed. The merge of main (#181 and #182, via P5) was reviewed for faithfulness, and found nothing.

Verification

At the current head (main through #176):

Node Step Result
26.12.1 pnpm run check 0 errors, 12 warnings
26.12.1 unit (alpha), and shuffled with seed 42 138 files; 2336 passed, 1 skipped
26.12.1 mock 9 files; 120 passed
26.12.1 rc channel, unit and mock same counts; back on alpha with no residue
26.12.1 coverage every floor held (the three new modules at 100)
26.12.1 build + scripts/check.ts passed
26.12.1 binary e2e, alpha and rc npm cells 15 passed, 2 HOST_LIMITATION skips each

CI is green on every check, catalog freshness included.

🤖 Generated with Claude Code

https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD

claude added 30 commits October 24, 2026 09:44
The vendor added kimi-k3.1-pro to the Go plane, so `catalog freshness`
went red on every branch of this stack. This takes the two generated
files exactly as the nightly refresh produced them (#111), with no
hand edits, and updates the counts that hard-code the catalog's size:
the Go shim test (28 -> 29), the plane table in redirect-planes.md
(Go served 28 -> 29, the no-SDK Go cell 17 -> 18), and the Go
completions list in both READMEs. The listed half of "29 served / 33
listed" is models.dev's count, inferred from the one added entry,
because models.dev cannot be reached from here.

It no-ops once main carries #111. P-T2 turns these counts into
invariants so a refresh stops needing this.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The plugin now serves the opencode and opencode-go routes itself,
through supported host paths only, and the hidden-route workaround is
gone.

A prepended internal/config listener hands pi-ai a copy of its config
without the two plane entries, so pi-ai keeps every other route. On a
commit the plugin reconciles: it builds one plane adapter, a subclass
of the host's PiAiAdapter, over pure profiles (utils/plane-profile,
plane-model, model-metadata and protocols) and registers only the
planes that are declared. A Settings candidate has the plane entries
it changes validated strictly. A read-only settings.describe graft
puts the committed plane entries back, so the host still sees them.

Deleted: responses-provider, responses-routes, google-bridge,
pi-provider and utils/google-replay; the listing hide and the
discovery decoration; the stream redirect; the D19 settings; and the
hidden ids in DEFAULT_PROVIDERS and cordis.patch.yml.

What users see: any saved id is accepted and served, and an id no
catalog knows dispatches as completions. The protocol comes from the
catalog and model info follows the user's own row first. A model
whose reasoning is only on or off offers Off/On. The default endpoint
is the per-protocol inference family. Keys resolve by pi-ai's own
rule, and a plane lists its declared ids even when no key resolves.

When several pi-ai rows declare planes, the row the plugin serves
stays the same while it is live and still declares one, so no row is
left stripped with nobody serving it. If the host's pi-ai module
cannot be read, the plugin steps aside even before any plane is
declared, so a later Settings save goes to pi-ai's own check.

The characterization rows this changes are flipped to new baselines;
every other row stays green unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
# Conflicts:
#	README.md
#	README.zh-CN.md
#	docs/redirect-planes.md
A measurement phase: the default endpoint family stays `modern`, so no
plugin behaviour changes and no characterization row flips.

- Name the default in one constant, AUTO_ENDPOINT_FAMILY in
  src/utils/plane-model.ts, which is what `auto` resolves to, and pin
  it in test/endpoint-family.test.ts.
- Extend the keyless matrix to three URL shapes (legacy, root, modern)
  over four protocols and two planes, add LEGACY_DISPATCH, and add one
  keyless free-model probe with its own pure classifier.
- Add minimal keyed probes (pure test/support/keyed-probes.ts and its
  e2e): one tiny request per plane, protocol and shape, sent with the
  plane's own key and the plugin's identity from one shared constant,
  PROBE_IDENTITY. Only the cells the default sends to are asserted;
  the rest are recorded.
- Gate the live job by tier with OPENCODE_E2E_KEYED (none, probes,
  full; unset means full). CI arms `probes` on a pull request that
  touches what the probes send, `full` nightly and on dispatch, and
  passes the secrets only when the tier is not `none`.
- Write a dated endpoint-family record from both live suites to the
  run summary and an `endpoint-families` artifact, and add §13 to
  docs/redirect-planes.md with every cell pending the first CI run.

The live part runs in CI only; no live result is invented here. A
failing keyed modern cell in CI is the evidence for a later `fix:`
that flips the default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
For the opencode and opencode-go routes, the Settings model list now
shows pi-ai's own rows first, in pi's order, and then every model the
plane's catalog can serve that pi does not list and the catalog has
not retired. Ids that pi's registry has retired are dropped, a field a
row lacks is filled from the catalog, and every row is cut down to the
five fields the host's discovery contract accepts, with absent values
omitted rather than set to undefined.

While pi-ai restarts and its discovery is withdrawn (NO_DISCOVERY),
the list answers the catalog rows alone instead of the error.

This rewrites the existing discoverModels wrapper rather than adding a
second one. Other routes keep today's enrich-only merge, because pi-ai
serves them and cannot serve an id it does not list. The plugin's own
model-discovery namespaces, which Settings never asked, are deleted
with their lifecycle tests, and RouteClaim gains a claiming() seam.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Phase P-T2 of docs/improvement-plan.md. Test-only: no source file
changes and no behaviour changes.

- Every socket-bound case is in the mock suite. The nine unit files
  that booted the mock gateway through testing-kit.ts are merged into
  test/mock/request-shapes.mock.ts and a new protocol-endpoints.mock.ts
  table. The two offline e2e files that bind a port
  (patched-fetch-headers, refusal-classification) moved there too. The
  device-login routes left the gateway mock.
- createMockContext, HarnessSimulator and the rest of testing-kit.ts
  are gone. Services are built on a real cordis Context, and
  lifecycle.test.ts mounts the plugin the way the Loader does
  (test/support/composition.ts). degradedHost remains only for the
  degraded-composition diagnostics.
- 43 cases that tested only the harness or the mock gateway are
  deleted. 33 duplicated cases are merged and 16 restatements are
  deleted; the plan names each one.
- Hard-coded catalog counts and vendor ids are now invariants, or a
  row picked by shape, so a vendor catalog refresh no longer breaks
  the suite by construction.
- The seven largest test files are split by subject, the live suites
  read their environment through test/support/e2e-env.ts, and the
  duplicated helpers and hard-coded ses_ ids are removed.
- src/utils/session-id.ts, src/opencode-store-contract.ts and the e2e
  environment reader have their own tests, and src/lifecycle.ts,
  src/stream-hook.ts and src/fetch-patch.ts have per-file coverage
  floors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The vendor renamed the Go plane's one Gemini model (dropping its
contributor suffix, halving its price and publishing an allowance for
it where the limits table had none) and added a free model with no
SDK, so `catalog freshness` went red on every branch of this stack.
This takes the two generated files exactly as the nightly refresh
produced them (#111), with no hand edits, and follows them:

- the Go Gemini fixtures in six test files (attachment-services,
  catalog, go-google, go-google-prepare, models-discovery,
  responses-routes) now name the renamed id, since each means "the
  Go Gemini model the catalog serves";
- the usage panel test built its unknown allowance from the table's
  one unpriced row, which the vendor has now priced, so it builds the
  `Number.NaN` allowance the generator emits itself;
- the Go shim count in catalog.test.ts (29 -> 30);
- redirect-planes.md: Go 29 -> 30 served, the no-SDK Go cell
  18 -> 19, and "0 of 29" -> "0 of 30" in the prose;
- both READMEs: the renamed Gemini id, and the new model in the Go
  completions list, since it declares no SDK.

The listed half of "30 served / 34 listed" is models.dev's count,
inferred from one rename (no change) and one addition (+1), because
models.dev cannot be reached from here. The dated S0 measurement row
in improvement-plan.md keeps the id it was measured with.

It no-ops once main carries #111.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The live routing suite picks its free-tier subjects from the catalog by
asking the gateway, but it counted "400 Upstream request failed: Model
is unavailable" as an observable answer. The upstream withdrew
nemotron-3-ultra-free while the catalog still lists it, so the picker
chose it and two cases asserted on a model the gateway no longer
serves; the reachability case also failed on a 429 throttle.

A withdrawn model (that 400, or a 410) is now skipped like a throttled
one. The free-tier routing case only accepts a candidate whose answer
is the free-tier gate it asserts, so an unmetered model cannot become
its subject, and the reachability walk moves past gated, withdrawn and
throttled candidates before it reports.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The review ran three rounds through the correctness, rules and matrix
lenses. What it found, and what changed:

- The binary e2e's beforeAll budget was smaller than the blocking
  subprocess deadlines it serializes. Each plugin install now has its
  own deadline, the hook's budget is derived from the installs and the
  boot, and afterAll stops a host a failed hook left running.
- providerWithApiKey claimed to be a line-for-line restatement but
  skipped upstream's credentialRef(ref) check. It now throws the same
  TypeError for a ref outside the grammar (a host-editor-contracts
  case pins it), and its comment names the deliberate differences.
- The pinned e2e-host cell let cordis and the loader float at patch
  level. The overrides now force both, the cache key includes them,
  and the job asserts them against HOST_VERSIONS.
- The pi-ai-first characterization asserted every facet under one
  KNOWN_DEFECT title. Each apply order now generates one test per row
  and facet, titled with that order's own tags.
- CONTRIBUTING said the contract tests pin F11-F20, and the plan said
  P-T1 pins every fact. Both now give the same accounting: which facts
  are pinned by number, which P-R1 exercises first, and why F9 and F17
  are not pinned.
- CONTRIBUTING put the e2e's dummy keys in the profile's credentials
  file; they are in the temporary home's credentials document.
- F5 had no real-host pin: host-shapes now pins that a route-level api
  and baseURL collapse pi's protocols onto one. F6 is recorded as first
  exercised by P-R1.
- The credential-mapping row pinned only the api-key branch of
  toPiCredential. host-credentials now covers all three branches, and
  the env branch is asserted through pi's Models.getAuth, so the case
  fails without it.
- The plan's reason for restating hasProviderApiKey was inaccurate; it
  now says no installed copy reaches the function.
- The new credential cases cited toPiCredential at the wrong lines;
  they now cite auth.ts:74-84.
- F4's listing and dispatch halves were pinned only by KNOWN_DEFECT
  rows P-R1 flips. A plugin-less tier-A case in host-shapes now pins
  that an id pi cannot place is not listed and that a turn on it is
  INVALID_CONFIG with no request; the save and deferred-read halves
  are tagged F4 too.
- The one facet that depends on the apply order lost its tag when the
  pi-ai-first block was split. The fixture case now checks only
  structure (the facets whose value moves are the facets whose tag
  moves), and the exact pin is its own KNOWN_DEFECT case that boots no
  host. CONTRIBUTING and the plan say P-R1 drops todayRowsFor's
  override and turns that case into a BASELINE check in the same diff.

Nothing under src/ changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The vendor renamed the Go plane's Gemini model from
gemini-4-argon-contributor to gemini-4-argon. The tier-B fixtures
(S0_PROFILE, S0_TODAY, CHARACTERIZED_PROFILE through S0, and
todayRowsFor's pi-ai-first override) declared the old id as the Go gap
id: one the plugin's catalog describes and pi 1.1.0 cannot place. After
the refresh the catalog no longer described it. They now name the
renamed id, which still plays that role because pi 1.1.0's opencode-go
table has no gemini-4-argon either. The host-shapes and editor-contract
cases follow the same fixture. The pi 1.3.0 note in mount-protocols
names that pi's own row, so it stays as it is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
What the review found, and what changed:

- rewrapOnAdaptersUpdated reinstalls its site inside the plugin's own
  teardown and on every foreign registry change. Its JSDoc in
  src/host/patch-method.ts now says so, counts the reinstalls a release
  causes, says a caller disposes it before releasing its adapters, and
  notes that a throw from a reinstall is logged by the host.
- The plan of record said all three P-H edge changes are unreachable on
  the real host for one reason; the third (the live-reload listing) is
  unreachable for a different one. docs/improvement-plan.md now gives
  each its reason.
- The tier-A reload cases for the listing and discovery sites proved the
  row only structurally. test/reload.test.ts now gives every site a
  tier-A probe whose decorated answer must differ from the host's own,
  so "survivor still decorates" and "last dispose restores" can fail.
- "patchMethod is the only way the plugin wraps a host method" was
  asserted in docs and enforced by nothing. test/architecture.test.ts
  now has a textual tripwire over everything apply() reaches, with a
  self-check of planted violations, and the apply()-twice reload case
  requires a patch record on every own function apply() leaves on the
  stand-in.
- The tripwire missed several write forms (Object.assign,
  Object.defineProperty/defineProperties, Reflect.setPrototypeOf,
  Object.setPrototypeOf, and an Object.* target reached through a
  property path such as registration?.adapter or this.llm). The
  patterns now catch them, and the self-check plants each one (17
  planted, up from 13). Nothing new in src/ matches.
- The docs said "any Reflect.* write" where the pattern matches a fixed
  set. The test docstring, AGENTS.md and the plan's P-H section now
  name the four Reflect and four Object methods matched, and why a
  prototype swap is listed.

No runtime behaviour changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The refreshed Go catalog serves its Gemini model as gemini-4-argon, so the
plane-dispatch mock, the plane-model cases and the binary e2e's probe
expectations name the new id; the Go Google base they assert is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The review ran three rounds (found 20, 5 and 8; upheld 19, 4 and 8).
What it found and what changed:

- A completions model whose effort list names none lost its Off.
  utils/model-metadata.ts now offers Off with none as its wire value
  on completions, as pi 1.1.0's own entries do; Responses unchanged.
  Pinned in model-metadata, plane-model and a new mock-gateway case.
- A Go entry with no apiKeyEnv authenticates with OPENCODE_API_KEY
  (pi's lookup, D20), and nothing said so. README "Changed in 1.x" and
  step 3 now name it; host-planes.test.ts pins both cases.
- A Settings save of a plane was refused as "cannot be validated yet"
  while the host modules were unloaded. host/route-claim.ts now judges
  it with the last modules that loaded; route-claim.test.ts pins it.
- Fiber.update(config) with noSave false would persist the stripped
  config and drop both planes. Recorded as a constraint in
  route-claim.ts and the plan; no caller does it today.
- Stale text: cordis-context.ts comments (stream redirect, isolate,
  root inject), deep-dive.md (pi's Go lookup, who answers Fetch),
  CONTRIBUTING (field count, the host-modules floor), and historical
  banners on opencode-parity-plan.md and upstream-findings.md.
- The mock body-shape row asserted only body.model. It now checks each
  protocol's required fields and that the gateway answered 200, or
  the vendor's 404 for the unknown id.
- Route-set rows: removing the last plane now pins replace([]) on the
  live handle, and "booting with none" waits for the plugin's row to
  be active instead of sleeping 50 ms.
- The live protocol-routing suite now sends paid models through the
  plane adapter on a tier-A host, not only raw probes.
- README's credential-isolation claim was false: the Go meter can send
  the Zen key. README.md, README.zh-CN.md, deep-dive.md,
  credentials.md and redirect-planes.md now give the real order and
  the 403 remedies; readme-parity.test.ts keeps both READMEs in step.
- The keySource hint described Automatic backwards. settings-copy.ts
  (en and zh) now gives literal key, captured key, then reference.
- The live adapter blocks dropped a protocol whose model was
  withdrawn. They now walk up to three candidates per protocol
  (support/live-walk.ts), pass a "model is unavailable" turn only when
  a raw probe confirms it (support/live-probe.ts), and skip naming a
  protocol no candidate reached.
- A mock comment claimed a body passed shape checks the mock lacks.

Declined: a toggle beside an effort list still offers no Off, which
moves baseline facets and needs the owner's decision; the Models
store's join stays a documented restatement rather than importing a
client UI package; the PR description is edited outside the tree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…ings

The tokenless plan step's build-approval guard named a root pnpmfile and
three global spellings that no case exercised: the known answer handed
buildApprovals a ready-made pnpmfile list, and it carried none of
globalPnpmfile, .npmrc's global-pnpmfile or a --global-pnpmfile flag, so
emptying the probe or dropping a spelling left the file green.

The probe is now pnpmfilesIn(root), read for the repository and for a
scratch root (empty, one file planted, both planted, a missing directory),
and the known answer carries each global spelling with its expected line.
Emptying PNPMFILES, either global key or the regex's global group now
turns the file red.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD

# Conflicts:
#	docs/improvement-plan.md
The keyless-label assertion read only the first row picked by its own
"a free model" prefix, so it held by construction and tied nothing to
`keyed: false`. Walk every printed variant row instead: it contains
"no key" exactly when its variant is keyless, and the keyless rows are
the known six (three free variants on each plane).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The plan said P5's pin additions landed first in their own `test:` commit
and that the change commit left them untouched. The phase is one commit,
which adds the pins itself. The sentence now says so, in P-R2's form, and
records the base run: both cases applied to fd3a6bc pass there, and a
control that expects the store service absent after a reload fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
No file conflicted. Resolutions, file by file:

- test/freshness-scope.test.ts: auto-merged; main's new es-module-lexer 3
  case ("reads a file off every loading form...") sits beside this
  branch's rewritten cases, both kept.
- scripts/freshness-scope.ts: main's es-module-lexer 3 port taken as is
  (this branch does not touch the file).
- package.json, pnpm-lock.yaml, channels/rc/pnpm-lock.yaml,
  pnpm-workspace.yaml: main's, unchanged (#177).
- src/catalog-data.ts, src/go-limits-data.ts: main's generated tables,
  unchanged (#178).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Brings in p-t3's merge of main: the #177 toolchain bump (vite-plus 1.5.0
with vitest 5.1.0 and the dev-dependency group, the es-module-lexer 3
port of scripts/freshness-scope.ts and test/freshness-scope.test.ts)
and the #178 refresh of the generated catalog and limits tables.

No file conflicted: p-r3's own change touches none of the files p-t3
changed, so every file merged automatically.

- package.json, pnpm-lock.yaml, channels/rc/pnpm-lock.yaml,
  pnpm-workspace.yaml: taken from p-t3 (main's #177) unchanged; p-r3
  does not touch them.
- scripts/freshness-scope.ts, test/freshness-scope.test.ts: taken from
  p-t3 unchanged (#177's es-module-lexer 3 port).
- src/catalog-data.ts, src/go-limits-data.ts: taken from p-t3 (main's
  #178) exactly; generated, never hand-edited.

The merged tree is p-r3's own change (its diff against 9911b30) on top
of the new parent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The merge applied without conflicts: p5's own change (src/host/remote.ts,
src/lifecycle.ts and its tests, docs, vite.config.ts, scripts/check.ts)
touches none of the files the new p-r3 head changes, so each file was
taken as git merged it:

- package.json, pnpm-workspace.yaml, pnpm-lock.yaml and
  channels/rc/pnpm-lock.yaml (#177): p-r3's, unchanged.
- scripts/freshness-scope.ts and test/freshness-scope.test.ts (#177's
  es-module-lexer 3 port): p-r3's, unchanged.
- src/catalog-data.ts and src/go-limits-data.ts (#178): p-r3's (main's),
  unchanged.

The merged tree is p5's own diff against its former parent applied on
top of the new p-r3 head, byte for byte.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The plane adapter hands pi-ai's prepareHeaders the plugin's per-call
headers and runs the host's llm-pi-ai/request-headers waterfall on the
planes. That seam first shipped in 0.2.2-alpha.3 and 0.2.2-rc.1, so the
@deepseek-ai/dsh-typert-protocol peer becomes >=0.2.2-alpha.3 <0.3.0.
The registry read re-run at landing found the seam in 0.2.2-alpha.3 and
0.2.2-rc.3 and not in 0.2.2-alpha.2.

This is an owner call at landing (plan design item 14) and lands as its
own commit so it can be reverted alone. The code detects the seam by
behaviour and still runs on a host without it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Credential handling in the fetch patch goes through one resolver.
src/utils/credential-policy.ts holds the pure decisions: one placeholder
filter applied at every decider's exit, the fill and meter orders per
keySource, the capture gate and the refusal count. src/credentials.ts is
the effect half: a capture store per root that the fill and the meter
share, and the one place the fill reads the process environment.

A key is now captured only from a request of a turn the stream hook
decorated, and a request on neither plane is filled only with a key its
own route sent there. A plane's key no longer reaches an arbitrary
provider-claimed URL, and a relay route's key never fills a plane
request or the meter. A captured key is dropped after a second
well-formed 401 in a row on its plane, counted only on decorated turns,
and is recorded again only after a decorated request carrying it is
accepted.

The global fetch install moves to src/host/global-fetch.ts. It reads
the original inside the effect and unwinds through disposed links, so
any disposal order ends at the fetch that was there, and both
KNOWN_DEFECT P6 assertions flip. The plane adapter sets the plane
headers per call through pi-ai's prepareHeaders and runs the host's
llm-pi-ai/request-headers waterfall on the planes, as pi-ai's own routes
do. The marker read moves to src/utils/request-shape.ts.

A parity pin over the four credential deciders was written and run
against the base before any source change. The tests, the docs, the
README pair and the plan record the change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
@viztor viztor changed the title refactor: one resolver for the fetch patch's credential fill fix: the fetch patch's credential fill Nov 16, 2026

viztor commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

catalog freshness is red because the vendor's catalog changed, not because of anything in this PR. On today's catalog the shim regenerates as Go 32 → 34 (+ hy4-flash-free, qwen4-max) and Zen 88 → 89 (+ hy4-flash-free). src/catalog-data.ts here is byte-identical to main's.

The check fails this PR because the diff touches the shim generator's inputs (src/models-catalog.ts, src/utils/request-shape.ts), so D23 makes it blocking. The regenerated table comes with tonight's nightly refresh. That gets ported to main and carried up the stack (#173 → #175 → #176 → here), which turns this check green.

The PR is now titled fix:, per the plan's P6 row. One more change is coming: the typert peer narrowing will be reverted, and the README pair will state the seam's floor instead. The reasoning will be in that commit when it lands.


Generated by Claude Code

claude and others added 5 commits November 16, 2026 12:09
…README

Reverts bf1b3b8: @deepseek-ai/dsh-typert-protocol keeps
>=0.2.1-alpha.1 <0.3.0 || >=0.2.2-0 <0.3.0. OC11 is met by stating the
llm-pi-ai/request-headers seam's floor (0.2.2-alpha.3, 0.2.2-rc.1) in the
README pair, with what a host without it does, not by the peer:

- #163 deliberately kept the optional cordis peer admitting the 0.2.1
  hosts' core;
- D26: host gaps are feature-detected, never compared by version;
- the plane adapter detects the seam by behaviour, and on a host without
  it the fetch patch still writes the plugin's session, origin and project
  headers (no turn is marked per call); only other plugins' contributors
  do not run on the planes there. Refusing those hosts at install buys
  nothing at runtime.

harness-channel keeps the registry's rc.3 facts under the old range, and
fetch-patch gains the OC11 case that performs that fallback.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…6 row

The P6 status row credited the owner with keeping the old typert peer
range, while design item 14 records the same decision as taken for the
owner. The row now says what the design item says.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…recorded

Design item 14's OC11 bullet said #163 "deliberately kept" the optional
cordis peer admitting the 0.2.1 hosts' core. #163's record does not
support the intent: it widened the peer to the 4.1 line for the rc
channel, verified 0.2.2-alpha.3 and 0.2.2-rc.2 only, and left the
existing 4.0.4/4.0.5 clauses in place without discussing 0.2.1. The
bullet now states that fact, matching the OC11 row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The nightly refresh (#182) added hy4-flash-free to both planes (Zen 88 -> 89, Go 32 -> 34 with qwen4-max on @ai-sdk/anthropic) and qwen4-max to the Go limits (29 -> 30). test/catalog-docs.test.ts held five doc counts to the old catalog; the docs follow it:

- README.md, README.zh-CN.md: the per-SDK routing table's no-SDK row 27 -> 28, the stated total 88 -> 89 (twice) and its date 2026-11-16; the Go plane's Chat Completions list gains hy4-flash-free and its Anthropic Messages list gains qwen4-max, so the lists stay the whole Go catalog. Kept in step for the docs-pairing gate.
- docs/protocol-routing-and-merge.md: every "N of 88" becomes "of 89", the no-SDK row 27 -> 28, the count date 2026-11-16, and the refresh history names #182.
- docs/redirect-planes.md: the served halves 88 -> 89 (Zen) and 32 -> 34 (Go); the shapes table's no-SDK row 27/21 -> 28/22 and Go Anthropic 5 -> 6; "0 of 89 on Zen, 0 of 34 on Go"; the Go non-completions sentence 11 -> 12; both count dates and histories name #182. The listed halves stay the ones #156 recorded, since the registry was not re-read.

No test pins a count any more (the catalog tests assert invariants), the Go limits count appears in no document, and no fixture names a moved row, so no test changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The catalog refresh added hy4-flash-free and qwen4-max to Go, and the
newest host cell's pi lacks both, so Settings' fetch on Go now appends
them there too. Three test comments still described an empty Go gap on
the newest cell; they now say what holds on every refresh. The phase
record in docs/improvement-plan.md keeps its statement, marked as true
at the time.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
The parenthetical beside the per-plane gap assertion said the newest
cell's pi lacks the catalog's newest ids. Nothing asserts that, and it
moves with pi's releases, so it now says only that which ids a cell's pi
lacks moves with the catalog and with pi.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…claude/vigilant-mendel-bctz9n-p-t3

No file conflicted. Twelve files came in from the parent; P-T3 had touched
two of them, in hunks git merged on its own:

- docs/redirect-planes.md: P-T3 rewrote the section 7 paragraph on the
  OPENCODE_E2E_KEYED tiers (a dispatch's `keyed` input, the composite setup
  action); the refresh moved the section 1 and 2 counts (Zen 89, Go 34, the
  no-SDK row 28/22, Go Anthropic 6, Go non-completions 12) and their #182
  stamp. Both kept: P-T3's paragraph, the parent's counts.
- docs/improvement-plan.md: P-T3 rewrote the phase table and its own P-T3
  entries; the refresh reworded one P-PD1 restack bullet (the newest cell's
  pi then listed every Go catalog model). Both kept.

Taken from the parent unchanged, P-T3 did not touch them: README.md,
README.zh-CN.md, docs/protocol-routing-and-merge.md, pnpm-workspace.yaml
(vite-plus and vite-plus-core 1.6.0), pnpm-lock.yaml and
channels/rc/pnpm-lock.yaml, src/catalog-data.ts and src/go-limits-data.ts
(generated), test/host-discovery.test.ts, test/host-planes-foreign.test.ts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…to claude/vigilant-mendel-bctz9n-p-r3

Brings in the parent's merge of main's toolchain bump (#181: vite-plus
and vite-plus-core 1.6.0, oxlint 1.93, oxfmt 0.78, both lockfiles
relocked, two test helpers moved to .then().catch()) and the nightly
refresh (#182: Zen 89 and Go 34 catalog models with hy4-flash-free and
qwen4-max, Go limits 30), followed through the README pair, the
protocol, redirect-planes and improvement-plan docs and two host tests.

No conflicts. README.md, README.zh-CN.md, docs/improvement-plan.md and
docs/redirect-planes.md were changed on both sides and merged cleanly in
separate hunks: this branch's refusal reporting rows and plan entries
beside the parent's catalog counts. The merged tree is this branch's own
change (ef74a26..0f97615) applied unchanged on top of the parent
(f36e849); the lockfiles and pnpm-workspace.yaml are the parent's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
…to claude/vigilant-mendel-bctz9n-p5

P-R3 now carries main's #181 (vite-plus 1.5.0 -> 1.6.0, oxlint 1.93,
both lockfiles relocked, two helpers moved to .then().catch()) and the
#182 catalog refresh (Zen 89, Go 34, Go limits 30) with its README pair,
routing and redirect-planes counts and the test subjects that moved.

No conflicts. README.md, README.zh-CN.md and docs/improvement-plan.md
auto-merged: P5 adds the usage-settings bullet to the README pair and
its P5 rows and sections to the plan; P-R3 changes the model counts and
lists in the README pair and one P-R2 restack sentence in the plan.
Each side's hunks are kept as written. The merged tree is P5's own
change (0f97615..6c599a5) on top of 71316be, line for line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
… claude/vigilant-mendel-bctz9n-p6

The new parent carries main's #181 (vite-plus and vite-plus-core 1.6.0,
oxlint 1.93, oxfmt 0.78, both lockfiles relocked, two test helpers
rewritten as .then().catch()) and the catalog refresh #182 (Zen 89, Go 34,
Go limits 30 models) with its follow-through in the README pair, the
protocol-routing and redirect-planes docs and two host tests.

No conflicts. README.md, README.zh-CN.md, docs/improvement-plan.md,
docs/redirect-planes.md and test/host-planes-foreign.test.ts merged
automatically: P6 and the parent touched different hunks of each. Both
lockfiles and pnpm-workspace.yaml come from the parent unchanged, since
P6 changes no dependency. The merged tree is P6's own change
(6c599a5..c424b21) on top of the parent, hunk for hunk; only a line
offset in test/host-planes-foreign.test.ts moved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
History only: main's tree equals the p5 tree (aa58754) this branch already contains.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
@viztor
viztor changed the base branch from claude/vigilant-mendel-bctz9n-p5 to main November 16, 2026 17:48
@viztor
viztor merged commit 54c6e83 into main Nov 16, 2026
9 checks passed
viztor pushed a commit that referenced this pull request Nov 16, 2026
History only: main's tree equals the p6 tree (0834b63) this branch already contains.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0141fKp5k6hiaJcP5ovhGtSD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants