Repository navigation
fix: don't merge request query into c.redirect() destinations - #705
Merged
Merged
Conversation
Handler, loader, and middleware redirects no longer copy the request query onto an internal path. routing.redirects still merge that query. A named action still places its key and keeps the page query. Co-authored-by: sayhola <sayhola@froq.me>
Config redirects still merge the request query into the destination. Co-authored-by: sayhola <sayhola@froq.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #648
Description
Took proposal 1 from the issue. Config
routing.redirectsstill merge the incoming request query into the destination.c.redirect()in handlers, loaders, and middleware sends exactly the location it is given, same idea as Next.js config redirects vsredirect()/NextResponse.redirect().Named-action redirects keep the existing action-key / page-query behavior. Absolute and protocol-relative destinations are unchanged. Docs updated in
docs/reference/api/rewrites.mdanddocs/guide/edge/redirects.md.Test
vp test run packages/void/test/unit/routing-runtime.test.ts -t 'code redirects and routing.redirects'vp test run packages/void/test/unit/routing-runtime.test.ts packages/void/test/unit/compile.test.tsvp test related --run packages/void/src/runtime/routing.ts --project unit --project unit-pglite --project cli-unitvp test run packages/void/test/integration/typed-routing-runtime.test.tsvp run --filter ./packages/void typecheck