Repository navigation
Fix lot of wire entities not calling WireLib.Remove on remove - #3753
Merged
Merged
Conversation
Because of this, a lot of stuff might not have been cleaned up, leading to memory leaks
Grocel
reviewed
Nov 6, 2026
Comment on lines
-459
to
-462
| function ENT:OnRemove() | ||
| WireLib.Remove(self) | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
This right to remove the WireLib.Remove(self) here after changeing all the code to call BaseClass.OnRemove(self) in other entities?
It looks like WireLib.Remove(self) is still not called.
Member
Author
There was a problem hiding this comment.
I made it call for everything in EntityRemoved, and calling BaseClass.OnRemove(self) is still good practice so no reason not to do it
Member
Author
There was a problem hiding this comment.
Oh actually it's not called for client now..., gonna fix that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of this, a lot of stuff might not have been cleaned up, leading to memory leaks