Repository navigation
fix(deps): move zip to 9.x and pyo3 to 0.29 for security advisories - #100
Merged
Merged
Conversation
zip below 9.0.5 is affected by parser-differential ("zip cloaking"),
symlink-target exhaustion and AES HMAC bypass advisories, and the
managed-runtime installer extracts downloaded zip archives with it.
pyo3 below 0.29 has an out-of-bounds read in PyList/PyTuple nth and a
missing Sync bound on closure-backed functions.
zip 9 makes ZipFile generic over its reader and entry names fallible,
so error messages now use the raw name lossily. pyo3 0.29 renames
with_gil to attach, allow_threads to detach and Bound::downcast to
cast. New tests extract a real zip and reject a parent-escaping entry.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
zipto 9.x andpyo3to 0.29 to clear the open advisories against them. This also unblocks the Pumas-Library guard-interop harness, which vendors this dependency graph and currently carries the same 6 alerts.Advisories addressed
inference's managed-runtime installer extracts downloaded zip archives with this crate.PyList/PyTuplenth/nth_back(high), a missingSyncbound onPyCFunction::new_closure(moderate), and aPyString::from_objectoverflow (low).Changes
zip = "9.0.5"(resolves to 9.4.1) andpyo3 = "0.29"(0.29.3). Both support the pinned toolchain: zip needs rustc 1.88, pyo3 needs 1.83.managed_runtime/archive.rs: zip 9 makesZipFilegeneric over its reader andname()fallible, so error messages now render the raw entry name lossily and can't fail on an undecodable name. New tests write a real zip, extract it, and reject a../escapeentry.Python::with_gil→Python::attach,allow_threads→detach, andBound::downcast→cast. No behavior change.Not addressed here
candle-core0.9.2-alpha.2 still brings its ownzip7.2.0 (and 1.1.4 in the legacysrc-tauri/Cargo.lock). Those alerts need a candle release that moves to zip 9.Verification
cargo check --locked --workspace --all-featuresand--no-default-featurespass.cargo clippy -p inference --all-targetsis clean.cargo test -p inference --features backend-pytorch --lib backend::passes 343 tests, including the embedded-Python tests.cargo test -p inference --lib managed_runtimepasses 67 tests, including the 2 new zip tests.🤖 Generated with Claude Code