Skip to content

fix(interop): repin the Pantograph guard harness past zip/pyo3 advisories - #110

Merged
MrScripty merged 1 commit into
mainfrom
fix/interop-harness-security
Nov 6, 2026
Merged

MrScripty merged 1 commit into
mainfrom
fix/interop-harness-security

Conversation

@MrScripty

Copy link
Copy Markdown
Owner

Resolves all 6 open Dependabot security alerts. They are all on rust/crates/pumas-core/tests/pantograph_guard_interop/Cargo.lock, which vendors Pantograph's dependency graph for the guard-interop harness.

Alert Severity Was Now
zip: parser differential / "zip cloaking" critical 2.4.2 9.4.1
zip: unbounded symlink-target handling high 2.4.2 9.4.1
zip: AES entry HMAC bypass on premature EOF moderate 2.4.2 9.4.1
PyO3: OOB read in PyList/PyTuple nth high 0.23.5 0.29.3
PyO3: missing Sync bound on new_closure moderate 0.23.5 0.29.3
PyO3: PyString::from_object overflow low 0.23.5 0.29.3

Both versions are set by Pantograph's inference crate, so the root fix landed there first: MrScripty/Pantograph#100.

Changes

  • run.py pins Pantograph d17b87efdf46797992d060211ffb0e33f647973c (the head of chore(deps-dev): Bump vite from 6.4.5 to 8.3.5 #100) and its guard blob 672c9818…. The README names the new commit.
  • Cargo.lock is regenerated from that checkout with --resolve-source-dependencies. The old lock was also stale against this workspace since chore(deps): land the November Dependabot updates #108 (it locked rusqlite 0.32.1), so the default offline run could no longer resolve; it does again now.
  • The matching accepted-exception row is removed from docs/SECURITY.md.

The newer upstream guard only adds two fixture fields (verification_source_fingerprint, verification_observed_from_cache_at), and validate is unchanged. The copied host-adapter slice now calls PumasArtifactEntryPath::parse, which is already in scope through pub use inference::*.

Verification

  • run.py --pantograph <d17b87e checkout> --resolve-source-dependencies passes 12 tests.
  • The default run.py --pantograph <checkout> (offline, --locked) passes 12 tests.
  • ruff check passes on run.py.

Merge order: MrScripty/Pantograph#100 needs to be merged with a merge commit (not squash), so that d17b87e stays reachable from Pantograph main.

🤖 Generated with Claude Code

…ries

The harness lock vendored Pantograph's dependency graph at 038dacaa,
which pinned zip 2.4.2 and pyo3 0.23.5. Those carry six open advisories
(zip cloaking, symlink-target exhaustion, AES HMAC bypass; PyO3 iterator
OOB read, missing Sync bound, PyString overflow). Pantograph now uses
zip 9.4.1 and pyo3 0.29.3 (MrScripty/Pantograph#100), so pin its head
commit and guard blob and regenerate the lock from it. The lock was also
stale against this workspace's rusqlite 0.41 and now resolves again. The
upstream guard only gained two fixture fields; all 12 harness tests pass
in both the resolving and the default offline locked runs.

Drop the matching accepted-exception row from SECURITY.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 89434064-6ec0-4b64-a29b-bc161c8447cd
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The inspected changes appear safe to merge; no actionable defect was established.

Summary

Repins the guard harness to Pantograph commit d17b87e and updates its dependency lock.

  • The interop harness uses a newer Pantograph snapshot and dependency lock.

No actionable issue was established. The harness was not run because the required Pantograph checkout was unavailable.

Reviews (1) · Last reviewed commit: "fix(interop): repin the Pantograph guard..." · Reviewed by Greptile

MrScripty added a commit that referenced this pull request Nov 6, 2026
#110 repins the harness to a Pantograph commit with patched zip and
pyo3 and regenerates the same lock, so keep this change to the
torch-server development floors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MrScripty
MrScripty merged commit 15bac8c into main Nov 6, 2026
35 checks passed
@MrScripty
MrScripty deleted the fix/interop-harness-security branch November 6, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant