Repository navigation
fix(interop): repin the Pantograph guard harness past zip/pyo3 advisories - #110
Merged
Merged
Conversation
…ries The harness lock vendored Pantograph's dependency graph at 038dacaa, which pinned zip 2.4.2 and pyo3 0.23.5. Those carry six open advisories (zip cloaking, symlink-target exhaustion, AES HMAC bypass; PyO3 iterator OOB read, missing Sync bound, PyString overflow). Pantograph now uses zip 9.4.1 and pyo3 0.29.3 (MrScripty/Pantograph#100), so pin its head commit and guard blob and regenerate the lock from it. The lock was also stale against this workspace's rusqlite 0.41 and now resolves again. The upstream guard only gained two fixture fields; all 12 harness tests pass in both the resolving and the default offline locked runs. Drop the matching accepted-exception row from SECURITY.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Contributor
[Low impact] The inspected changes appear safe to merge; no actionable defect was established. SummaryRepins the guard harness to Pantograph commit
No actionable issue was established. The harness was not run because the required Pantograph checkout was unavailable. Reviews (1) · Last reviewed commit: "fix(interop): repin the Pantograph guard..." · Reviewed by Greptile |
MrScripty
added a commit
that referenced
this pull request
Nov 6, 2026
#110 repins the harness to a Pantograph commit with patched zip and pyo3 and regenerates the same lock, so keep this change to the torch-server development floors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 6 open Dependabot security alerts. They are all on
rust/crates/pumas-core/tests/pantograph_guard_interop/Cargo.lock, which vendors Pantograph's dependency graph for the guard-interop harness.PyList/PyTuplenthSyncbound onnew_closurePyString::from_objectoverflowBoth versions are set by Pantograph's
inferencecrate, so the root fix landed there first: MrScripty/Pantograph#100.Changes
run.pypins Pantographd17b87efdf46797992d060211ffb0e33f647973c(the head of chore(deps-dev): Bump vite from 6.4.5 to 8.3.5 #100) and its guard blob672c9818…. The README names the new commit.Cargo.lockis regenerated from that checkout with--resolve-source-dependencies. The old lock was also stale against this workspace since chore(deps): land the November Dependabot updates #108 (it locked rusqlite 0.32.1), so the default offline run could no longer resolve; it does again now.docs/SECURITY.md.The newer upstream guard only adds two fixture fields (
verification_source_fingerprint,verification_observed_from_cache_at), andvalidateis unchanged. The copied host-adapter slice now callsPumasArtifactEntryPath::parse, which is already in scope throughpub use inference::*.Verification
run.py --pantograph <d17b87e checkout> --resolve-source-dependenciespasses 12 tests.run.py --pantograph <checkout>(offline,--locked) passes 12 tests.ruff checkpasses onrun.py.Merge order: MrScripty/Pantograph#100 needs to be merged with a merge commit (not squash), so that
d17b87estays reachable from Pantographmain.🤖 Generated with Claude Code