Repository navigation
test(core): remove the Pantograph guard harness from Pumas - #113
Conversation
The interop harness compiled a pinned Pantograph checkout's admission guard inside this repository and committed Pantograph's full dependency lock. Pantograph is a consumer: it uses Pumas through its public API, and its own admission rules belong in its own repository. Nothing in CI ran the harness, but every Pantograph dependency in its lock was reported as a Pumas security alert. The Pumas-side guarantees it checked are already covered by hf_load_target_tests: canonical package identity, revision and observation token, read-only snapshots through relative and symlink roots, no cache mutation in ReadOnlyIndexed, and reobservation after package drift. Add the one partial gap as a Pumas-only test: OwnerFresh rebuilds a missing Summary row that matches the public summary API, and the response round-trips through JSON unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
[Low impact] This PR appears safe to merge. SummaryRemoves the standalone Pantograph guard harness and its dependency lockfile without changing production code.
Reviews (1) · Last reviewed commit: "test(core): remove the Pantograph guard ..." · Reviewed by Greptile |
|
custody_guard_hf_stage_proofs_preserve_followers_and_refuse_stale_use : takes deep breath : failed only because the github runner is super slow and cant make the disk write within the time limit. |
Removes
rust/crates/pumas-core/tests/pantograph_guard_interop/: Pantograph code and Pantograph's 3,736-line dependency lock, which were committed inside Pumas.Why
Pantograph is a consumer. It depends on Pumas through the public API (it pins
pumas-libraryby Git revision) and should never have code here. The harness compiled a pinned Pantograph checkout's admission guard against local Pumas. That gave Pumas:Coverage
Of the 12 harness tests, 5 tested Pantograph's own guard rejecting bad input: primary-weight path, blank fingerprint, and revision, identity and contract mismatches. Those belong in Pantograph.
The Pumas-side guarantees were already covered by
hf_load_target_testsin Pumas's own terms, usually more strictly:hf_owner_target_projects_canonical_package_identity_revision_and_observationhf_indexed_resolution_is_an_immutable_snapshot_…,hf_expected_owner_observation_is_enforced_…hf_read_only_{relative,symlink}_root_preserves_summary_and_detail_snapshothf_owner_reobserves_metadata_file_mtime_and_upstream_revision,hf_indexed_resolution_…hf_summary_and_detail_targets_have_identical_observation_tokensOne case was only partly covered, so it is added as a Pumas-only test,
hf_owner_fresh_restores_a_missing_summary_and_round_trips_on_the_wire. It checks that OwnerFresh rebuilds a missing Summary row matching the public summary API, and that the response round-trips through JSON unchanged.The
pumas-coreREADME now says consumers check their admission rules against the public contract in their own repositories.Verification
cargo test --offline --locked -p pumas-library --lib hf_load_target_tests: 21 passed, including the new test.cargo fmt --checkis clean.dependabot.ymlor the release tooling referenced the harness path.Supersedes #112.
🤖 Generated with Claude Code