Skip to content

test(core): remove the Pantograph guard harness from Pumas - #113

Merged
MrScripty merged 2 commits into
mainfrom
test/remove-pantograph-harness
Nov 6, 2026
Merged

MrScripty merged 2 commits into
mainfrom
test/remove-pantograph-harness

Conversation

@MrScripty

Copy link
Copy Markdown
Owner

Removes rust/crates/pumas-core/tests/pantograph_guard_interop/: Pantograph code and Pantograph's 3,736-line dependency lock, which were committed inside Pumas.

Why

Pantograph is a consumer. It depends on Pumas through the public API (it pins pumas-library by Git revision) and should never have code here. The harness compiled a pinned Pantograph checkout's admission guard against local Pumas. That gave Pumas:

Coverage

Of the 12 harness tests, 5 tested Pantograph's own guard rejecting bad input: primary-weight path, blank fingerprint, and revision, identity and contract mismatches. Those belong in Pantograph.

The Pumas-side guarantees were already covered by hf_load_target_tests in Pumas's own terms, usually more strictly:

Harness check Existing Pumas test
Target path is the package directory, plus revision and fingerprint identity hf_owner_target_projects_canonical_package_identity_revision_and_observation
ReadOnlyIndexed never mutates cache rows hf_indexed_resolution_is_an_immutable_snapshot_…, hf_expected_owner_observation_is_enforced_…
Relative and symlink read-only roots keep the owner's target hf_read_only_{relative,symlink}_root_preserves_summary_and_detail_snapshot
Reobservation changes the fingerprint hf_owner_reobserves_metadata_file_mtime_and_upstream_revision, hf_indexed_resolution_…
Summary and Detail rows give the same token hf_summary_and_detail_targets_have_identical_observation_tokens

One case was only partly covered, so it is added as a Pumas-only test, hf_owner_fresh_restores_a_missing_summary_and_round_trips_on_the_wire. It checks that OwnerFresh rebuilds a missing Summary row matching the public summary API, and that the response round-trips through JSON unchanged.

The pumas-core README now says consumers check their admission rules against the public contract in their own repositories.

Verification

  • cargo test --offline --locked -p pumas-library --lib hf_load_target_tests: 21 passed, including the new test.
  • cargo fmt --check is clean.
  • Nothing in CI, dependabot.yml or the release tooling referenced the harness path.

Supersedes #112.

🤖 Generated with Claude Code

The interop harness compiled a pinned Pantograph checkout's admission
guard inside this repository and committed Pantograph's full dependency
lock. Pantograph is a consumer: it uses Pumas through its public API,
and its own admission rules belong in its own repository. Nothing in
CI ran the harness, but every Pantograph dependency in its lock was
reported as a Pumas security alert.

The Pumas-side guarantees it checked are already covered by
hf_load_target_tests: canonical package identity, revision and
observation token, read-only snapshots through relative and symlink
roots, no cache mutation in ReadOnlyIndexed, and reobservation after
package drift. Add the one partial gap as a Pumas-only test: OwnerFresh
rebuilds a missing Summary row that matches the public summary API, and
the response round-trips through JSON unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3276b934-ce67-4950-9dbb-d707252c10aa
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Removes the standalone Pantograph guard harness and its dependency lockfile without changing production code.

  • Pumas drops the Pantograph guard harness and points consumers to their own contract checks.
  • Pumas tests check that OwnerFresh repairs Summary data and preserves its target on the wire.

MrScripty explicitly intends to remove Pantograph-specific guard coverage because those checks belong in Pantograph.

Reviews (1) · Last reviewed commit: "test(core): remove the Pantograph guard ..." · Reviewed by Greptile

@MrScripty

Copy link
Copy Markdown
Owner Author

custody_guard_hf_stage_proofs_preserve_followers_and_refuse_stale_use : takes deep breath : failed only because the github runner is super slow and cant make the disk write within the time limit.

@MrScripty
MrScripty merged commit a60ed41 into main Nov 6, 2026
59 of 60 checks passed
@MrScripty
MrScripty deleted the test/remove-pantograph-harness branch November 6, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant