Repository navigation
Publish: install linked es5 dependencies for react - #24
Merged
Merged
Conversation
The react package links es5 via a file: devDependency, so es5's own dependencies must be installed first (same fix as ci.yml).
…iled; lengthen npm visibility retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The react publish job failed with missing modules because react depends on es5 via a
file:devDependency. Adds the same pre-install stepci.ymluses (npm ciin the es5 package), only for react and only when it needs publishing.After merge, re-run via
workflow_dispatch(a failed-jobs re-run would use the old workflow file). Already-published versions are skipped.