Skip to content

Publish: install linked es5 dependencies for react - #24

Merged
kmonahan merged 3 commits into
mainfrom
fix-publish-react-install
Nov 5, 2026
Merged

kmonahan merged 3 commits into
mainfrom
fix-publish-react-install

Conversation

@kmonahan

@kmonahan kmonahan commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

The react publish job failed with missing modules because react depends on es5 via a file: devDependency. Adds the same pre-install step ci.yml uses (npm ci in the es5 package), only for react and only when it needs publishing.

After merge, re-run via workflow_dispatch (a failed-jobs re-run would use the old workflow file). Already-published versions are skipped.

The react package links es5 via a file: devDependency, so es5's own
dependencies must be installed first (same fix as ci.yml).
@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

When the React package version is not already published, the workflow now runs npm ci in the linked ES5 package directory before its existing per-package dependency installation.

Merge Risk: Minimal · up to 33c94

The publish workflow now installs the linked ES5 dependencies first. No merge-blocking issue was established.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title names the main change: the publish workflow now installs the linked es5 dependencies before publishing react. The raw summary confirms that the workflow adds an npm ci step in the es5 packag…
Description check Passed The description states the failure cause (react depends on es5 through a file: devDependency), the fix (an npm ci step in the es5 package, only for react and only when it needs publishing), and the po…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the publish workflow now installs the linked es5 dependencies before publishing react. The raw summary confirms that the workflow adds an npm ci step in the es5 package for the react matrix package. The title is specific and matches the changeset.

Full details: Description check

Explanation

The description states the failure cause (react depends on es5 through a file: devDependency), the fix (an npm ci step in the es5 package, only for react and only when it needs publishing), and the post-merge rerun steps. All of these match the changeset described in the raw summary.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: fe0ee8ca-81ce-43ca-8897-e3331c31b150
Commits

Reviewing files that changed from the base of the PR and between 2a7a5ec and 33c9445.

Files selected for processing: 1

  • .github/workflows/publish.yml

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@kmonahan
kmonahan merged commit f7fbf4a into main Nov 5, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant