Skip to content

Publish: install linked es5 dependencies for react #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmonahan merged 3 commits into from
Nov 5, 2026
Merged

Publish: install linked es5 dependencies for react #24

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33c9445
Publish: install linked es5 dependencies before react publish
kmonahan Nov 5, 2026
055b38e
Publish: run GitHub Packages job even if another package's publish fa…
kmonahan Nov 5, 2026
611cb00
Merge branch 'main' into fix-publish-react-install
kmonahan Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ jobs:
echo "needed=true" >> "$GITHUB_OUTPUT"
fi

# The react package depends on the es5 package via a `file:` link, so
# es5's own dependencies (e.g. @eslint/js) must be installed too.
- name: Install es5 Dependencies (linked by react)
if: steps.check.outputs.needed == 'true' && matrix.package == 'eslint-config-forumone-react'
working-directory: ./packages/eslint-config-forumone-es5
run: npm ci

- name: Install Dependencies
# tiny-mustache has no lockfile or dependencies
if: steps.check.outputs.needed == 'true' && hashFiles(format('packages/{0}/package-lock.json', matrix.package)) != ''
Expand Down Expand Up @@ -121,15 +128,15 @@ jobs:
echo "tag=$TAG" >> "$GITHUB_OUTPUT"

# The version must be on npm (published now or earlier) before we release it.
# Registry metadata can lag a freshly published version, so retry for ~90s.
# Registry metadata can lag a freshly published version (we've seen ~75s), so retry for ~2.5 min.
ON_NPM=false
for attempt in 1 2 3 4 5 6; do
for attempt in 1 2 3 4 5 6 7 8 9 10; do
if [[ -n "$(npm view "@forumone/eslint-config-es5@$VERSION" version 2>/dev/null || true)" ]]; then
ON_NPM=true
break
fi
echo "Attempt $attempt: @forumone/eslint-config-es5@$VERSION not visible on npm yet."
[[ $attempt -lt 6 ]] && sleep 15
[[ $attempt -lt 10 ]] && sleep 15
done
if [[ "$ON_NPM" != "true" ]]; then
echo "@forumone/eslint-config-es5@$VERSION is not on npm; not creating a release."
Expand All @@ -153,7 +160,10 @@ jobs:
# so call the GitHub Packages workflow directly.
publish-es5-github:
needs: release-es5
if: needs.release-es5.outputs.created == 'true'
# !cancelled() is required: without a status function, GitHub implicitly adds
# success(), which also fails when any *earlier* job in the chain (e.g. one
# package's publish-npm leg) failed, and would skip this job.
if: ${{ !cancelled() && needs.release-es5.outputs.created == 'true' }}
uses: ./.github/workflows/release-eslint-config-es5.yml
with:
tag_name: ${{ needs.release-es5.outputs.tag }}
Expand Down
Loading