Skip to content

fix(nav3): Reject colliding navigation argument keys - #6714

Open
0xadam-brown wants to merge 2 commits into
mainfrom
0xadam-brown/fix/nav3-duplicate-argument-keys
Open

0xadam-brown wants to merge 2 commits into
mainfrom
0xadam-brown/fix/nav3-duplicate-argument-keys

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

📜 Description

Navigation 3 now drops an entry’s arguments with the reason duplicate_key when distinct map keys produce the same string. The destination name remains available, and unrelated entries can still include their arguments.

💡 Motivation and Context

Navigation argument maps stringify their keys before they are sent to Sentry. For example, keys 1 and "1" both become "1", so one value currently overwrites the other silently. Rejecting that entry’s arguments avoids reporting an incomplete map as though it were the original data.

addresses: JAVA-787 (link)

💚 How did you test it?

  • Regression test

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

This fix can be reviewed and merged independently of the mapper stack. Removing its counterpart from the stack will be handled separately.

Drop an entry’s arguments when distinct map keys stringify identically, rather than silently reporting an incomplete map.

Refs JAVA-787
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 20, 2026
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR risk: medium

For commit 043d719.

Main concerns: data sent to Sentry, reach, host performance.

This label is a hint for reviewers, not an approval.

@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@0xadam-brown
0xadam-brown force-pushed the 0xadam-brown/fix/nav3-duplicate-argument-keys branch from 1ce397b to 043d719 Compare November 20, 2026 16:18
@0xadam-brown
0xadam-brown marked this pull request as ready for review November 20, 2026 16:18
@0xadam-brown
0xadam-brown requested review from a team and adinauer as code owners November 20, 2026 16:18
@0xadam-brown
0xadam-brown requested review from romtsn and runningcode and removed request for a team November 20, 2026 16:18
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@0xadam-brown 0xadam-brown added the sanity-check PR needs a lightweight review for obvious issues label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium sanity-check PR needs a lightweight review for obvious issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant