Repository navigation
fix(nav3): Reject colliding navigation argument keys - #6714
Open
0xadam-brown wants to merge 2 commits into
Open
0xadam-brown wants to merge 2 commits into
0xadam-brown wants to merge 2 commits into
Conversation
Drop an entry’s arguments when distinct map keys stringify identically, rather than silently reporting an incomplete map. Refs JAVA-787
Contributor
PR risk: mediumFor commit Main concerns: data sent to Sentry, reach, host performance. This label is a hint for reviewers, not an approval. |
📲 Install BuildsAndroid
|
0xadam-brown
force-pushed
the
0xadam-brown/fix/nav3-duplicate-argument-keys
branch
from
November 20, 2026 16:18
1ce397b to
043d719
Compare
0xadam-brown
marked this pull request as ready for review
November 20, 2026 16:18
0xadam-brown
requested review from
romtsn and
runningcode
and removed request for
a team
November 20, 2026 16:18
5 of 9 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Navigation 3 now drops an entry’s arguments with the reason
duplicate_keywhen distinct map keys produce the same string. The destination name remains available, and unrelated entries can still include their arguments.💡 Motivation and Context
Navigation argument maps stringify their keys before they are sent to Sentry. For example, keys
1and"1"both become"1", so one value currently overwrites the other silently. Rejecting that entry’s arguments avoids reporting an incomplete map as though it were the original data.addresses: JAVA-787 (link)
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
This fix can be reviewed and merged independently of the mapper stack. Removing its counterpart from the stack will be handled separately.