Repository navigation
fix(nav3): [Part 5] Reject ambiguous argument map keys - #6701
Draft
0xadam-brown wants to merge 2 commits into
Draft
0xadam-brown wants to merge 2 commits into
0xadam-brown wants to merge 2 commits into
Conversation
This was referenced Nov 20, 2026
Contributor
PR risk: mediumFor commit Main concerns: data sent to Sentry, reach, host performance. This label is a hint for reviewers, not an approval. |
5 of 9 tasks
📲 Install BuildsAndroid
|
This was referenced Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Serial Name Mappers)
📜 Description
When distinct argument map keys become the same recorded string, Sentry now drops that entry’s arguments and records
duplicate_key. The destination name is preserved, and a collision by itself does not discard other back stack entries’ arguments.💡 Motivation and Context
Navigation argument map keys are recorded as strings, so distinct application keys such as
1and"1"can become indistinguishable in Sentry. Keeping just one value would present an incomplete map as though it were the application’s original data.addresses: JAVA-787 (link)
💚 How did you test it?
Nav3 release build and all 447 unit tests passed. Repository-wide
make format api, Spotless checks, ABI validation, and Detekt passed.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Continue with PR 6: Share bounded argument conversion.