Skip to content

fix(nav3): [Part 4] Preserve events with non-finite arguments - #6700

Draft
0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-3from
feat/nav3-serial-name-mappers-4
Draft

0xadam-brown wants to merge 2 commits into
feat/nav3-serial-name-mappers-3from
feat/nav3-serial-name-mappers-4

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

⚠️ DO NOT REVIEW: Duplicates #6713. I'll remove this PR and rebase the stack once #6713 has been merged.

PR Stack (Nav3 Serial Name Mappers)


📜 Description

Sentry now records non-finite navigation argument values as the strings "NaN", "Infinity", and "-Infinity". This preserves their diagnostic meaning in a form that JSON can represent, and their text counts toward the existing argument budget so the fallback does not bypass payload limits.

💡 Motivation and Context

Navigation arguments can legitimately contain NaN or an infinite number, but JSON cannot represent those values as numbers. Passing them through unchanged can therefore prevent the event carrying the navigation data from being serialized, turning one unusual argument into the loss of an otherwise useful event.

addresses: JAVA-787 (link)

💚 How did you test it?

Nav3 release build and all 446 unit tests passed. Repository-wide make format api, Spotless checks, ABI validation, and Detekt passed.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Continue with PR 5: Reject ambiguous argument map keys.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR risk: medium

For commit 627ad3c.

Main concerns: data sent to Sentry, host performance, reach.

This label is a hint for reviewers, not an approval.

@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title fix(nav3): [Nav3 Mappers 4] Preserve events with non-finite arguments fix(nav3): [Part 4] Preserve events with non-finite arguments Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant