Repository navigation
build(nav3): [Part 3] Compose lifecycle dependency is now compileOnly - #6699
Open
0xadam-brown wants to merge 2 commits into
Open
0xadam-brown wants to merge 2 commits into
0xadam-brown wants to merge 2 commits into
Conversation
This was referenced Nov 20, 2026
Contributor
PR risk: mediumFor commit Main concerns: dependencies customers inherit, public contract, reach. Rules that block low also fired:
This label is a hint for reviewers, not an approval. |
This was referenced Nov 20, 2026
📲 Install BuildsAndroid
|
This was referenced Nov 20, 2026
0xadam-brown
marked this pull request as ready for review
November 20, 2026 14:19
0xadam-brown
requested review from
markushi and
runningcode
and removed request for
a team
November 20, 2026 14:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Serial Name Mappers)
📜 Description
sentry-android-navigation3no longer supplies its own version of the Compose lifecycle dependency, but instead relies on the host app to provide it, ie, we now use acompileOnlyconfig rather thanimplementation.Let's us match the common sentry-java convention and avoids running the risk of dependabot updating the dependency at some point and bringing host apps along for the ride.
(The original use of
implementationrather thancompileOnlywas a clanker decision rather than being principled / meaningful.)Update does not affect any existing Nav3 applications who consume
sentry-android-navigation3.💡 Motivation and Context
Nav3 applications already depend on lifecycle Compose through
navigation3-ui, which is an inevitable part of the application's AndroidX dependency graph.addresses: JAVA-787 (link)
💚 How did you test it?
n/a
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Continue with PR 4: Preserve events with non-finite arguments.