Repository navigation
test(nav3): [Part 11] Verify mapping after R8 minification - #6708
Open
0xadam-brown wants to merge 1 commit into
Open
0xadam-brown wants to merge 1 commit into
0xadam-brown wants to merge 1 commit into
Conversation
This was referenced Nov 20, 2026
Contributor
PR risk: mediumFor commit The model rated this change low. It was raised to medium because:
This label is a hint for reviewers, not an approval. |
4 of 9 tasks
📲 Install BuildsAndroid
|
0xadam-brown
force-pushed
the
feat/nav3-serial-name-mappers-10
branch
from
November 20, 2026 14:00
7a34760 to
f7b850a
Compare
0xadam-brown
force-pushed
the
feat/nav3-serial-name-mappers-11
branch
from
November 20, 2026 14:00
5ddd798 to
7d85cf6
Compare
0xadam-brown
marked this pull request as ready for review
November 20, 2026 16:01
0xadam-brown
requested review from
romtsn and
runningcode
and removed request for
a team
November 20, 2026 16:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Nav3 Serial Name Mappers)
📜 Description
Adds critical regression tests for SerialName and SerialNameAndProperties in R8-minified Android apps. Ordinary unit tests don't exercise shrinking, optimization, or obfuscation, so they can't establish whether serializer lookup, destination names, and property encoding still work in a release build.
The suite is run weekly on an emulator, and it has four configurations: R8 full and compatibility modes, each against the minimum supported and pinned latest kotlinx.serialization versions. It checks expected names, arguments, and sensitive-key filtering, and verifies that R8 actually renamed representative classes and fields. (See the next PR in this series for the GitHub workflow that runs these tests weekly.)
The fixture relies on kotlinx.serialization’s consumer rules and targeted app-side rules rather than blanket keep rules. This exercises the configuration host apps need, including named-companion lookup and its expected fallback behavior when the necessary rules are absent.
💡 Motivation and Context
The built-in mappers must honor serialization names and property filtering after an application's code has been minified or else all nav destinations will appear as "/unknown" in the Sentry UI.
addresses: JAVA-787 (link)
See the "Callouts" section in #6705 for info about our use of
AbstractEncoderand why that makes the R8 tests in this PR especially valuable.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Continue with PR 12: Keep compatibility coverage current.
#skip-changelog