Repository navigation
Preserve empty relative paths during normalization - #208
Open
theman6660 wants to merge 1 commit into
Open
theman6660 wants to merge 1 commit into
theman6660 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalizing an empty-path relative reference changes its
rootedflag, so resolving it against a base URL can discard the base path. For example, normalizing?x=1before clicking it fromhttp://example.com/a/bresolves tohttp://example.com/?x=1instead ofhttp://example.com/a/b?x=1.Only add the empty-path slash when a host is present. Regression tests cover empty, query-only, fragment-only, and combined references through URL and DecodedURL; existing absolute-host slash normalization remains covered.
Validation on Windows / Python 3.12:
git diff --checkpass. Older interpreter matrix not run.Found during source inspection. Implementation, tests, and this description were prepared with OpenAI Codex at my request.