Repository navigation
Fix line-segment intersection for scaled homogeneous endpoints - #282
Open
Doribelove wants to merge 1 commit into
Open
Doribelove wants to merge 1 commit into
Doribelove wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the line
y = 0, the segment from(0, 1)to(1, 2)lies entirely above the line. Passing the same second endpoint as(-1, -2, -1)previously reported an intersection. A small positive homogeneous scale could also make an off-line endpoint pass the endpoint tolerance check.Normalize finite homogeneous endpoints to unit weight before applying the existing side and tolerance tests. Regression cases cover a same-side segment, a crossing segment, and a small positive scale.
Validation:
python -m pytest -q tests/test_geom2d.py tests/test_geom3d.py(60 passed, including the new parameterized regression).