Repository navigation
Validate transition styles without waiting for the animation - #68
Merged
Merged
Conversation
daun
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
swup validate'stransition-stylescheck was flaky under load. It addedis-animating, waited a fixedduration + 100msand then read the computed styles. With--parallelon a slow CI runner (e.g. 61 pages on a 2-core GitHub runner), Chromium falls behind rendering. The transition often hadn't moved yet after the fixed wait, so valid sites failed withStyles not changed.This PR removes the waiting entirely:
transition: none !important; animation: none !importantis-changingvs.is-changing is-animating. These now resolve instantly to their end valuesThe duration is still verified separately by the
transition-durationcheck.Also adds
bypassCSPso thatvalidateAnimationStylesworks against websites using a CSP (style tag injected).Testing
Against the swup docs site (61 pages):
swup validate --parallel: 61/61 passed (previously 17 failures on CI)--styles=color(a property that doesn't change): correctly fails withStyles not changedNote
addStyleTaginjects an inline<style>, so a strict CSPstyle-srccould block it. Can addbypassCSPto the page context if needed.Checks
mainbranchnpm run lint)npm run test)